__setstate__ has been replaced but doc doesn't mention it.

By chance I came upon https://github.com/FreeCAD/FreeCAD/commit/83d4080fe86a8d98dfab87763623f8a1bd76bf43#diff-962944a6433fa21a1f6824e9b8e91ec4515e862eec9f60eeb22b2de063c7f656

which states that setstate and getstate have been renamed.

However the doc has not been updated : https://wiki.freecad.org/Create_a_FeaturePython_object_part_II

I am not sure about it, so I prefer to ask before changing the wiki chennes

FYI: it is not just that page that needs to be updated. Several other pages describe these functions.

How is it possible that such important methods are replaced without deprecation warning? This is a breaking change that would have required a new major version.

As a maintainer of the official FreeCAD macro repository I’d have expected to be informed.

wmayer yorik chennes

Gaël

PS: I tried to have a small bug fixed not so long time ago. The forum topic didn’t attract much attention but the few reactions I had were all saying that breaking changes should not be introduced. So I take this opportunity to attract attention again for the issue and make an appeal to fix the bug.

Realthunder proposed a backwards-compatibility solution so that older versions of Python could still use the old method names, but it hasn’t been turned into a PR yet.