do we need the word Techdraw for commands?

Translation
1

Capture d’écran 2023-07-10 145409.png
new strings have been added in particular for Techdraw workbench and I wonder if we do need to have the word Techdraw for each command.

I know as a translator, I can omit them if I want.

2

wandererfan did you put these new strings?
I am not behind FreeCAD for the moment to check the commands receiving the wording Techdraw.

3

AFAIK, I haven’t added any new strings, but they look like they are coming from TechDraw/Gui/Workbench.cpp. Maybe here?

#if 0// needed for Qt's lupdate utility
    qApp->translate("Workbench", "Dimensions");
    qApp->translate("Workbench", "Extensions: Attributes/Modifications");
    qApp->translate("Workbench", "Extensions: Centerlines/Threading");
    qApp->translate("Workbench", "Extensions: Dimensions");
    qApp->translate("Workbench", "Annotations");
    qApp->translate("Workbench", "Stacking");
    qApp->translate("Workbench", "Add Lines");
    qApp->translate("Workbench", "Add Vertices");
    qApp->translate("Workbench", "TechDraw");
    // Translations for View > Toolbars
    qApp->translate("Workbench", "TechDraw Annotation");
    qApp->translate("Workbench", "TechDraw Attributes");
    qApp->translate("Workbench", "TechDraw Centerlines");
    qApp->translate("Workbench", "TechDraw Clips");
    qApp->translate("Workbench", "TechDraw Decoration");
    qApp->translate("Workbench", "TechDraw Dimensions");
    qApp->translate("Workbench", "TechDraw Extend Dimensions");
    qApp->translate("Workbench", "TechDraw File Access");
    qApp->translate("Workbench", "TechDraw Pages");
    qApp->translate("Workbench", "TechDraw Stacking");
    qApp->translate("Workbench", "TechDraw Tool Attributes");
    qApp->translate("Workbench", "TechDraw Views");
    qApp->translate("Workbench", "Views");
    qApp->translate("Workbench", "Extensions: Centerlines/Threading");
#endif

It looks like toolbars have the TechDraw prefix, but menu items do not. Maybe toolbars need to have a unique name?

    Gui::ToolBarItem* stacking = new Gui::ToolBarItem(root);
    stacking->setCommand("TechDraw Stacking");
    
    Gui::MenuItem* stacking = new Gui::MenuItem;
    stacking->setCommand("Stacking");
4

thank you for your feedback.

giving a closer eye to the toolbars, I have never noticed that each sub toolbar for any workbench is receiving a name. my bad.

sorry for the noise, we have to keep as it is.
and now I have to double check consistency for the other workbenches…

edit: to have single text is much better. Still I don’t understand why we have Techdraw Remove Prefix for example. It’s not the name of a toolbar, It’s a command as far as I can see.

5

chennes checking different wb, it appears sub toolbars don’t systematically receive the name of the wb. For ex, it is the case with Arch wb, it is not with Mesh wb.
may a rule to edit for the developper hanbook.

6

digging, checking one by one the wb and sub toolbars, I don’t think it is so simple.

take Part wb, in the menu, under Part, we have ‘Booleans’ which is perfect. The sub toolbar is also called for the moment ‘Boolean’. If we put ‘Part Boolean’, I suspect the menu will also received the same wording, which IMO is not nice.
take Arch wb, with this wb we also ha some tools coming from Draft wb and to identify the sub toolbars, they receive either Arch or Draft, which we don’t have in the menu.

from my poor understanding, it is case by case.