Material improvements

ian.rees · September 25, 2018, 4:53am

Apologies for the delay - I’ve rebased Eivind’s work on to the latest master at https://github.com/ianrrees/FreeCAD_tinkering/commits/20170226-material2-rebase . Haven’t been able to compile it yet, as my machine is only setup for building against Python 3 at the moment, which wasn’t supported by the old branch.

ian.rees · September 25, 2018, 5:47am

OK, I’ve got a compile (pushed a few fixes to my branch), but am running in to a crash on startup, which seems to relate to initialising Python types. I’m really rusty in this area, and can’t see an easy solution:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff54eab38 in PyUnicode_InternInPlace () from /usr/lib/x86_64-linux-gnu/libpython3.6m.so.1.0
(gdb) bt
#0  0x00007ffff54eab38 in PyUnicode_InternInPlace () from /usr/lib/x86_64-linux-gnu/libpython3.6m.so.1.0
#1  0x00007ffff54eac0d in PyUnicode_InternFromString () from /usr/lib/x86_64-linux-gnu/libpython3.6m.so.1.0
#2  0x00007ffff5595545 in PyType_Ready () from /usr/lib/x86_64-linux-gnu/libpython3.6m.so.1.0
#3  0x00007ffff5597408 in PyType_Ready () from /usr/lib/x86_64-linux-gnu/libpython3.6m.so.1.0
#4  0x00007ffff5b0fac2 in Py::PythonType::readyType (this=0x5555557b60f0)
    at /home/irees/Projects/freecad-code/src/CXX/Python3/cxx_extensions.cxx:283
#5  0x00007ffff64866e3 in Py::SolidMaterialArray::init_type ()
    at /home/irees/Projects/freecad-code/src/App/PropertyPartMaterial.cpp:321
#6  0x00007ffff64860f4 in Py::PropertyPartMaterial::init_type ()
    at /home/irees/Projects/freecad-code/src/App/PropertyPartMaterial.cpp:423
#7  0x00007ffff64d4615 in App::Application::initTypes ()
    at /home/irees/Projects/freecad-code/src/App/Application.cpp:1359
#8  0x00007ffff64d4421 in App::Application::init (argc=1, argv=0x7fffffffdbe8)
    at /home/irees/Projects/freecad-code/src/App/Application.cpp:1253
#9  0x000055555555c38e in main (argc=1, argv=0x7fffffffdbe8)
    at /home/irees/Projects/freecad-code/src/Main/MainGui.cpp:192

bernd · September 25, 2018, 3:22pm

Great compiles and starts for me on Python2 . It even rebases on the latest commits from master

OS: Debian GNU/Linux 9.5 (stretch)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14805 (Git)
Build type: Unknown
Branch: materialian2
Hash: e16950459ae4e9c8e9ffd3852f8ccbe017443d01
Python version: 2.7.13
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.0.0
Locale: German/Switzerland (de_CH)

first find … it is not possible to load a saved file. Not one saved with master not one saved with this branch.

bernd · October 23, 2018, 9:34pm

It still rebases on master https://github.com/berndhahnebach/FreeCAD_bhb/commits/materialian

but still the problems resist …

first find … it is not possible to load a saved file. Not one saved with master not one saved with this branch.

bernd · February 27, 2019, 5:17pm

https://github.com/berndhahnebach/FreeCAD_bhb/commits/materialeivind

still rebases, but not the material editor ui, but this is no that important. C++ code is still not finished. It would be a pitty if this development would be for trash eventually.

eivindkvedalen · March 31, 2019, 10:53pm

Rebased on current master: https://github.com/eivindkv/FreeCAD/tree/Material2

It compiles, and it didn’t crash when I opened a file

Eivind

bernd · April 2, 2019, 9:30am

Great! it is compiling … Seams yor are still on Python2 At the moment I switched back to Py2 too because I had some compile error on Py3. I well report back.

bernd · April 2, 2019, 4:57pm

Just a quote from eivind an ealier post to know what is this branch about:

hxmuller:

Things more or less done:

Added a MaterialDatabase class. This is the collection of various sources described below. Material queries happens from this database.

Added a DefaultMaterialSource class. This source is read-only and contains the original pre-defined materials that could be selected in FreeCAD. It also contains a DEFAULT material, that all other materials can inherit from, to ensure that visual properties are defined.

Added a DocumentMaterialSource class. Per-document materials are stored here. If visualization materials are changed, a copy is stored here.

Added a FileMaterialSource class. FCMat materials cards are provided by this source. Multiple sources may be added (system/user).

Added a PropertyPartMaterial class. This class and its helper classes encapsulates materials for solids and surfaces.

Added a PropertyPartMaterial member Material to Part::Feature, along with its Shape.

I’ve been focusing on the data structure part now; almost nothing is done on the Gui part, except propagating material colors from the Material property to the view provider, so the colors of the parts change.

I have also added a Python interface (this is what I actually use for testing), and a typical use-case could be:
App.ActiveDocument.Box.Material.setSolidMaterial(0, "PLA");
This will assign the PLA material to solid 0 of Box. Properties can then be queried, e.g
App.ActiveDocument.Box.Material.Solid[0].YoungsModulus
Surface materials are accessed as e.g
App.ActiveDocument.Box.Material.Solid[0].setSurfaceMaterial(0, "GOLD")
(provided that Solid[0] has been set first).

The material databases are accessed either at
App.getMaterialDatabase()
or
doc.MaterialDatabase
(ideally they should have the same syntax; something for later). The material database in App is the application-wide database, so adding/removing/editing materials should be possible to do without an open document. The material database in the document links to the application-wide one, but also provides a private material source for materials specific for the document.

The file-based materials are supposed to be in either
getResourceDir() + "/Mod/Material/StandardMaterial"
or
getUserAppDataDir() + "Materials"

bernd · April 2, 2019, 5:16pm

with Python2 and Qt5 I am able to compile this branch. But as soon as an object which has a Shape property is created FreeCAD crashes. Files with meshes or for example an FEM file without the shape saves and reopens fine.

OS: Debian GNU/Linux buster/sid (KDE//usr/share/xsessions/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16369 (Git)
Build type: Unknown
Branch: materialeivind
Hash: 159b004261e6fc932af376978710911aee26fc4e
Python version: 2.7.16rc1
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: German/Switzerland (de_CH)

eivindkvedalen · April 2, 2019, 6:54pm

I discovered that as well, and I’m looking into it now…

Eivind

bernd · April 29, 2019, 7:48pm

https://github.com/FreeCAD/FreeCAD/pull/2102 see 3651b9b8 add basic card handling. Far far from your development but much better than we had.

If you find a minute it still would be cool to get it at least working without crash.

bernd

Erni24 · August 9, 2019, 9:24pm

I tried compiling the Material fork too. The compiling rebased to upstream worked well for Python3 and Qt5.
But starting the application results in a crash in PropertyPartMaterial.cpp in function SolidMaterialArray::init_type()

Py::PropertyPartMaterial        ::init_type(); from Application.cpp

SolidMaterialArray::init_type(); line 423 from PropertyPartMaterial.cpp

    behaviors().readyType(); line 321 from PropertyPartMaterial.cpp

Because the coupling C++ to Python is new to me, I have to discover this for a while…

Dietmar

Program received signal SIGSEGV, Segmentation fault.
#0  /lib/x86_64-linux-gnu/libc.so.6(+0x37840) [0x7f7a29a44840]
#1  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyTuple_New+0xf7) [0x7f7a2c12e427]
#2  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyType_Ready+0x1ab2) [0x7f7a2bf8eb62]
#3  /lib/x86_64-linux-gnu/libpython3.7m.so.1.0(PyType_Ready+0x1ee8) [0x7f7a2bf8ef98]
#4  0x7f7a2c90dd7e in Py::PythonType::readyType() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADBase.so+0x1c
#5  0x7f7a2d2c494e in Py::SolidMaterialArray::init_type() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x69
#6  0x7f7a2d2c43d0 in Py::PropertyPartMaterial::init_type() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x16
#7  0x7f7a2d313480 in App::Application::initTypes() from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x1a0
#8  0x7f7a2d31329b in App::Application::init(int, char**) from /home/dietmar/Code/FreeCAD/freecad-build-master/lib/libFreeCADApp.so+0x35
#9  /home/dietmar/Code/FreeCAD/freecad-build-master/bin/FreeCAD(main+0x6b8) [0x562b10108cb7]
#10  /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f7a29a3109b]
#11  /home/dietmar/Code/FreeCAD/freecad-build-master/bin/FreeCAD(_start+0x2a) [0x562b101084ca]
*** Beendet mit Rückgabewert: 01 ***

bernd · August 11, 2019, 6:56pm

Since I am a Python guy I am not of a big help here. That is the main reason nothing has been fixed in this branch, because IMHO the would be a big step forward in materials in FreeCAD.

Best to do is to encapsulate the problem and ask a specific question in developer part of the forum. For sure I will help with testing if you would do further developing.

bernd

Erni24 · August 12, 2019, 7:24pm

Ok, I will do so

bernd · August 19, 2019, 5:21am

The big App::Link merge has taken place. On rebase I get merge conflicts in a few files:

       von beiden geändert:    src/App/DynamicProperty.cpp
        von beiden geändert:    src/App/DynamicProperty.h
        von beiden geändert:    src/App/Property.h
        von beiden geändert:    src/App/PropertyExpressionEngine.cpp
        von beiden geändert:    src/App/PropertyStandard.cpp
        von beiden geändert:    src/Mod/Spreadsheet/App/Cell.cpp

If you are still on this it might makes sense to rebase to up to date master.

Erni24 · August 23, 2019, 4:40pm

Something for this weekend…

eivindkvedalen · August 23, 2019, 6:05pm

The big App::Link merge has taken place. On rebase I get merge conflicts in a few files:

       von beiden geändert:    src/App/DynamicProperty.cpp
        von beiden geändert:    src/App/DynamicProperty.h
        von beiden geändert:    src/App/Property.h
        von beiden geändert:    src/App/PropertyExpressionEngine.cpp
        von beiden geändert:    src/App/PropertyStandard.cpp
        von beiden geändert:    src/Mod/Spreadsheet/App/Cell.cpp

If you are still on this it might makes sense to rebase to up to date master.

I managed to compile it on a rebased master today.

Eivind

bernd · August 28, 2019, 10:45am

wow which branch on https://github.com/eivindkv/FreeCAD? On Py2 or Py3?

How about this ?

Kunda1 · August 28, 2019, 5:19pm

Off-topic, but just wanted to say, Nice to see you

eivindkvedalen · September 6, 2019, 7:05pm

Eivind